Add flang-activation #27470
Add flang-activation #27470
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/flang-activation/meta.yaml:
|
|
@isuruf, this should handle the flang compiler activation split, PTAL! :) I added you as a maintainer, please let me know if you'd prefer not to be. |
|
Gentle ping @isuruf |
Suggested-By: Isuru Fernando <isuruf@gmail.com>
Co-Authored-By: Isuru Fernando <isuruf@gmail.com>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Thanks for the review - that should all be fixed now. |
For consistency with other conda-forge compilers, c.f. e.g. https://github.com/conda-forge/ctng-compiler-activation-feedstock/blob/main/recipe/activate-gcc.sh Suggested-By: Isuru Fernando <isuruf@gmail.com>
|
Anything else here @isuruf? |
|
Gentle ping @isuruf |
|
Any last comments here @isuruf? |
recipes/flang-activation/meta.yaml
Outdated
| # rename flang-new -> flang is happening soon: | ||
| # https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462 |
There was a problem hiding this comment.
This is an updated version from what we currently have in the flang feedstock. As it was looking like it would finally happen a few days ago (until the goalposts shifted yet again), I was debating with myself whether we want to do the rename for flang 19 already. Might make the fortran migration a bit simpler. 🤷
There was a problem hiding this comment.
I didn't mean the contents of the comment. I was referring to why this comment needs to be in the test section. It seems irrelevant.
There was a problem hiding this comment.
It's more visible in the recipe than in the activation script, and the test section is where we're using the name (or now, the value of FC).
|
Thanks for the review! 🙏 |
|
Good to merge now? |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
|
Thanks for iterating on this. We can keep polishing things on the feedstock, flang 19.1.0 GA is around the corner anyway. :) |
Address conda-forge/flang-feedstock#63