Make the package noarch for Linux and Mac #191
Conversation
ccordoba12
requested review from
andfoy,
dalthviz and
steff456
as code owners
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
…nda-forge-pinning 2024.09.29.16.11.30
| entry_points: | ||
| - spyder = spyder.app.start:main | ||
| osx_is_app: true | ||
| # https://github.com/conda/conda-build/issues/5385 |
There was a problem hiding this comment.
wow i forgot about this. glad i opened an issue for it......
|
I guess you need to weigh the reduction in the jobs against the added complexity and linter failures.... |
I'm fine with the complexity (I don't think it makes things too different from what we have right now). But I was about to ask you if there's something we can do about the linter, i.e. is there something like |
|
i'm not too sure. I'm half thinking if there is a way to maybe fix the offending character in the ico file... |
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.09.29.16.11.30
|
well 1/2 of the linter warnings gone .... |
|
hmm, seems like this is a real problem: #192 (comment) |
|
So, is the linter failure a bug in conda-smithy? |
|
No. It’s actually indicating that the new dependency necessitates an arch dependent package. |
|
Ok, I see. The problem is A couple of additional questions for you:
|
|
So i'm helping with PRs, but..... |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Ok with conda-forge/fcitx-qt5-feedstock#5 merged soon you should be good to go. |
That's awesome! Thanks @hmaarrfk!
We received several requests about that. And I don't know about other Qt packages that provide input facilities on Linux for East Asian languages. So, I prefer to deal with that inconvenience rather than not giving those users a better out of the box experience when working with Spyder. |
|
understood! |
I always thought that this was Gnome's job, to provide some input language and that the editors were just receiving some unicode codepoint to display... |
I think the problem is Conda envs are like chroots (not exactly virtual machines but like a Linux system within the host one). Since they come with their own set of Xorg/Qt/Gtk packages, they can't use the facilities provided by the host system. |
this sounds like a real conda-forge problem. I don't know anybody that uses Pinyin type inputs on Ubuntu and I've never used it myself so I can't really test.... |
I think so too, in the sense that conda-forge on Linux is close to be the conda-forge Linux distro. But since many people wanted things to work out of the box in conda-forge envs (i.e. without worrying about what system packages they had to to install), it was inevitable. |
ccordoba12
force-pushed
the
make-package-norach
branch
from
45ce368 to
8786c3e
Compare
conda-forge.yml
Outdated
| noarch_platforms: | ||
| - linux_64 | ||
| - osx_64 | ||
| - win_64 |
There was a problem hiding this comment.
@hmaarrfk, do we need win_64 here or can we remove it for now?
Other than that, this should be ready to go, right?
There was a problem hiding this comment.
i think we need it, otherwise it won't trick conda-smithy to generate the windows builds. maybe. i'm not sure, try without it?
That's because we're only building a noarch version for Mac and Linux
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.24.16.28.23
|
Ok, I think this one is ready. Thanks @hmaarrfk for all your help with it! |
|
Great. Hopefully this helps more than it causes churn |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)