Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python312 #109

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python312.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6289987330, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mikemhenry
Copy link
Contributor

Looks like all the py3.12 builds failed with the same module not found error when importing openmm

@peastman
Copy link
Contributor

This seems to be the problem:

Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/openmm_1695565080132/work/build/python/setup.py", line 10, in <module>
    from distutils.core import setup
ModuleNotFoundError: No module named 'distutils'

distutils is removed in 3.12. We need to update our setup.py script.

@mikemhenry
Copy link
Contributor

@peastman I think from setuptools import setup should be enough, I was thinking just adding a patch to the recipe, do you think that would be okay?

@peastman
Copy link
Contributor

The fix is in openmm/openmm#4245. Since 3.12 isn't even officially released yet, let's just wait and support it in OpenMM 8.1 (beta hopefully due out Really Soon Now).

@mikemhenry mikemhenry marked this pull request as draft September 26, 2023 19:38
@mikemhenry
Copy link
Contributor

Sounds good! I will mark this as a draft so we don't lose track of it when we release 8.1

@jakirkham jakirkham mentioned this pull request Oct 6, 2023
3 tasks
@jaimergp
Copy link
Member

py312 builds for stable were added a while ago in #120, so closing this.

@jaimergp jaimergp closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants