-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install c/sdk_info.h public header #16
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Actually that flag also installs a static library that is also included in the librerun.so, so ideally it would be great to only install the required header. I can look into patching rerun to do that in half an hour. |
…nda-forge-pinning 2024.08.20.12.29.15
…nda-forge-pinning 2024.08.20.12.29.15
5bcccac
to
8337aab
Compare
@jeongseok-meta I opened rerun-io/rerun#7246 upstream to fix the issue, and backported it here. I also added a test to build a minimal example, to avoid having such regressions in the future. |
Sounds good! Maybe we need to set |
Good point, I forgot that. |
…nda-forge-pinning 2024.08.20.12.29.15
Thanks @jeongseok-meta ! |
This PR aims to resolve build errors with rerun C++ sdk 0.18: https://github.com/facebookincubator/momentum/actions/runs/10474666427/job/29009464723?pr=52#step:4:188
0.18 added rerun sdk_info.hpp, which requires a header file in a subdirectory,
c/sdk_info.h
. The C header is installed only whenRERUN_INSTALL_RERUN_C
isON
. Not sure if there would be any negative effect by this though..0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)