Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install c/sdk_info.h public header #16

Merged
merged 16 commits into from
Aug 20, 2024

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Aug 20, 2024

This PR aims to resolve build errors with rerun C++ sdk 0.18: https://github.com/facebookincubator/momentum/actions/runs/10474666427/job/29009464723?pr=52#step:4:188

/home/runner/work/momentum/momentum/.pixi/envs/default/include/rerun/sdk_info.hpp:4:10: fatal error: c/sdk_info.h: No such file or directory
    4 | #include "c/sdk_info.h"
      |          ^~~~~~~~~~~~~~

0.18 added rerun sdk_info.hpp, which requires a header file in a subdirectory, c/sdk_info.h. The C header is installed only when RERUN_INSTALL_RERUN_C is ON. Not sure if there would be any negative effect by this though..

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta changed the title Install c rerun Install rerun c Aug 20, 2024
@jeongseok-meta jeongseok-meta marked this pull request as ready for review August 20, 2024 16:08
@traversaro
Copy link
Contributor

Actually that flag also installs a static library that is also included in the librerun.so, so ideally it would be great to only install the required header. I can look into patching rerun to do that in half an hour.

@traversaro traversaro changed the title Install rerun c Install c/sdk_info.h public header Aug 20, 2024
@traversaro
Copy link
Contributor

@jeongseok-meta I opened rerun-io/rerun#7246 upstream to fix the issue, and backported it here. I also added a test to build a minimal example, to avoid having such regressions in the future.

@jeongseok-meta
Copy link
Contributor Author

@jeongseok-meta I opened rerun-io/rerun#7246 upstream to fix the issue, and backported it here. I also added a test to build a minimal example, to avoid having such regressions in the future.

Sounds good! Maybe we need to set RERUN_INSTALL_RERUN_C back to OFF to see if the fix works even without installing rerun c?

@traversaro
Copy link
Contributor

@jeongseok-meta I opened rerun-io/rerun#7246 upstream to fix the issue, and backported it here. I also added a test to build a minimal example, to avoid having such regressions in the future.

Sounds good! Maybe we need to set RERUN_INSTALL_RERUN_C back to OFF to see if the fix works even without installing rerun c?

Good point, I forgot that.

@traversaro
Copy link
Contributor

Thanks @jeongseok-meta !

@traversaro traversaro merged commit 2a5a851 into conda-forge:main Aug 20, 2024
25 checks passed
@jeongseok-meta jeongseok-meta deleted the install_c_rerun branch August 20, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants