Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Windows build #67

Merged
merged 7 commits into from
Jul 3, 2021
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jul 2, 2021

The PR updates the CMake-based buildsystem by adding and removing the files that changed from Ipopt 3.13 to 3.14 .
Fix #64 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro changed the title [WIP] Re-enabled Windows build [WIP] Re-enable Windows build Jul 2, 2021
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro changed the title [WIP] Re-enable Windows build Re-enable Windows build Jul 2, 2021
@traversaro traversaro changed the title Re-enable Windows build [WIP] Re-enable Windows build Jul 2, 2021
@traversaro
Copy link
Contributor Author

The PR is ready for revidew @conda-forge/ipopt .

@traversaro traversaro changed the title [WIP] Re-enable Windows build Re-enable Windows build Jul 2, 2021
recipe/meta.yaml Outdated
@@ -13,8 +13,7 @@ source:
- pkg-config-do-not-add-requires-private.patch

build:
number: 0
skip: true # [win]
number: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to bump, this doesnt change existing unix packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 1bc668f .

@jschueller jschueller merged commit bdfea8b into conda-forge:master Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt CMake build scripts for Ipopt 3.14.0
3 participants