Bump to the 1.58 series and add Windows support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Ah, hmm. Meson requires Python 3. So if we want to commit to the Meson build system for packages that provide Python assets — as this one does — we'll need to drop Python 2.7 support. Personally, I'm feeling pretty OK with that, but it's something to think about ... |
|
This is blocked until the next release of Meson comes out, because the macOS builds are failing due to a bug fixed in the as-yet-unreleased PR mesonbuild/meson#4187. |
This was referenced Jan 8, 2019
Closed
pkgw
added a commit
to pkgw/meson-feedstock
that referenced
this pull request
Jan 25, 2019
In my testing, mesonbuild/meson#4187 is necessary to successfully compile conda-forge/gobject-introspection-feedstock#9 on macOS. This patch can be taken out whenever the next Meson release comes out.
4 tasks
By switching to the Meson build system, it becomes tractable to build on Windows. The price is that Meson only works on Python >= 3.6, so we need to drop support for older Pythons even though gobject-introspection nominally supports them. In my judgment this is OK. We still need a few patches to get everything working on all three platforms, but nothing too invasive.
…da-forge-pinning 2019.01.21
mesonbuild/meson#4827 contains my diagnosis of what's going on. We can work around with environment variables.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new series supports the Meson build system, which makes it tractable to start building this on Windows.