Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Add patches for WASM support #58

Closed
wants to merge 5 commits into from

Conversation

IsabelParedes
Copy link
Member

@IsabelParedes IsabelParedes commented Jul 12, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@IsabelParedes IsabelParedes marked this pull request as ready for review July 12, 2024 10:05
@IsabelParedes IsabelParedes marked this pull request as draft July 12, 2024 10:33
Comment on lines +27 to +29
-DLLVM_DEFAULT_TARGET_TRIPLE=wasm32-unknown-emscripten \
-DLLVM_TARGETS_TO_BUILD=WebAssembly \
-DLLVM_ENABLE_PROJECTS="clang;flang;mlir" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To understand, you want to build a compiler that runs on linux and compiles for emscripten? Not sure if our clang already supports that target; in any case, building clang/flang/mlir in the same feedstock will almost certainly time out.

We'll need to come up with a larger-scale plan for how we want to support wasm/emscripten in conda-forge, but as an experiment, I could imagine pushing this into a separate label conda-forge/label/llvm_<...>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want to build a compiler that runs on linux and compiles for emscripten?

Exactly.

I don't think it's necessary to rebuild clang. Emscripten uses clang internally.

For pushing to a new label, could I make the changes in this PR or should that be separate?

@IsabelParedes IsabelParedes marked this pull request as ready for review July 16, 2024 12:36
@IsabelParedes
Copy link
Member Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits July 16, 2024 12:38
…, and conda-forge-pinning 2024.07.16.07.04.17"

This reverts commit c47debe.
@IsabelParedes
Copy link
Member Author

Hi! I'm not sure why this is failing when it passed before and there are no changes...
Anyhow, closing this for now to create a new flang variant in a separate PR.

@h-vetinari
Copy link
Member

The linux failures I'm not sure about, but the windows builds time out on this feedstock quite regularly unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants