Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new build: fix openmp issue #19

Merged
merged 4 commits into from
Jan 31, 2021
Merged

new build: fix openmp issue #19

merged 4 commits into from
Jan 31, 2021

Conversation

xoviat
Copy link
Contributor

@xoviat xoviat commented Jan 31, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@xoviat xoviat requested a review from isuruf as a code owner January 31, 2021 18:23
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@xoviat xoviat marked this pull request as draft January 31, 2021 18:23
@xoviat
Copy link
Contributor Author

xoviat commented Jan 31, 2021

this build should resolve this issue: https://ci.appveyor.com/project/xianyi/openblas/builds/37531215/job/8bsnwgmaw3ahnjgh#L116887

note: this is not a regression from flang 5.0.0, because OpenMP was not working on 5.0.0.

Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@xoviat
Copy link
Contributor Author

xoviat commented Jan 31, 2021

fix confirmed.

@xoviat xoviat marked this pull request as ready for review January 31, 2021 18:52
@xoviat
Copy link
Contributor Author

xoviat commented Jan 31, 2021

@conda-forge-admin rerender

@xoviat
Copy link
Contributor Author

xoviat commented Jan 31, 2021

cc @isuruf

@isuruf isuruf merged commit ab32e02 into conda-forge:master Jan 31, 2021
@xoviat xoviat deleted the patch-1 branch January 31, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants