-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify conda-build so that it gets updated. #983
Conversation
# conda-build 3.17 and crytography seem to pull in different versions of openssl | ||
# this causes problems in the build system | ||
# therefore, specify that the higher conda-build version should take precedence | ||
packageSpecs: 'python=3.6 conda-build>=3.17 conda conda-forge::conda-forge-ci-setup=2' # Optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add this condition to conda-forge-ci-setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure I can. I feel like it would just downgrade conda-forge-ci-setup, so that it still respects the 2.x pin, but has a higher version of openssl.
Those downgrades are because of adding the channel conda-forge. |
Ah you are right. So how come it isn't finding the modern conda-build without the specifier? |
that's conda's behaviour. You have to add the packages to the conda command that you want to be the latest of. Can you send a PR adding |
conda-forge-ci-setup=2
Ok that seems to do it I added it to a few other CIs in this case too. |
I guess at this point, your other solution is equally valid, but i feel like under most circumstances we want an updated version of conda-build right? |
Man, sample sizes of 1 are useless. These builds got updated to conda-build 3.17.5, but still fail. I'm not really sure if this PR fixes any immediate problem. |
@jakirkham it seems that there is some issue with cryptography and conda-build 3.17 in terms of which version of openssl they want to pull in.
See my green builds:
https://ci.appveyor.com/project/conda-forge/scikit-image-feedstock/builds/21372670
But more importantly, see how they downgrade cryptography and openssl
https://ci.appveyor.com/project/conda-forge/scikit-image-feedstock/builds/21372670/job/n45cx54g0scn0kw4?fullLog=true#L154
I'll probably cut a new release of scikit-image with this "mod" when the other CIs pass
conda-forge/scikit-image-feedstock#39
FYI: @jni
Checklist
news
entry