-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests #16
add tests #16
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2022.04.01.00.07.17
@isuruf There's however some confusion (at least to me) with the various environments here - this feedstock is really only designed to be pulled in at |
@isuruf |
As the package name says, this is for building an autotools package and the test you are adding is not for an autotools package. |
It's intended to be a minimal reproducer of #15, using the documented calls from the documentation in I don't really understand your point - I'm happy to adapt the tests however necessary (or indeed remove them) - but currently |
I don't think you understand what a autotools project is. See https://www.gnu.org/software/automake/manual/html_node/Autotools-Introduction.html |
I do get the The point is that the documentation of how to use this feedstock does not work even with the full monty of an autotools build, c.f.
in conda-forge/ffmpeg-feedstock#126 (hmaarrfk/ffmpeg-feedstock@73461b1). I don't know how important |
It could be that the fix is documentation-only, but since it worked before, it seemed like there's more to it. |
Yes
No, ffmpeg is not an autotools project. Please try a project using this package like |
OK, closing this. I'm thinking the log message for calling |
Wanted to fix #15, found I had some uncommitted tests lying around. Let's try these first.