-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwind border-radius support #6657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15251 Bundle Size — 58.11MiB (+0.01%).eca2537(current) vs d1d46c1 master#15247(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch feature/tailwind-border-radius Project dashboard Generated by RelativeCI Documentation Report issue |
bkrmendy
approved these changes
Nov 19, 2024
seanparsons
approved these changes
Nov 20, 2024
liady
approved these changes
Nov 20, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Make border-radius controls work in tailwind projects. **Fix:** - Add the border-radius shorthand/longhand props to the StyleInfo interface - Add overflow prop to the StyleInfo interface (necessary because when we set the border-radius we set the element to overflow: hidden) - Update InlineStylePlugin and TailwindStylePlugin to support the new props in StyleInfo - Refactor the set-border-radius strategy and the border-radius control handle control to read element styles through a StyleInfoReader instance - Add a new property patcher in style-plugins@patchers to take care of patching removed border-radius props - Add a new EditorState substate so we can get a StyleInfoReader in a useEditorState hook without using the full store - Remove the condition in tailwind-compilation that `ElementsToRerenderGLOBAL.current` has to be `'rerender-all-elements'` for the tailwind classes to be regenerated. For some reason this blocked the class generation after a border-radius interaction. We are still protected against tailwind class generation during the interaction (we check `isInteractionActive`) - Add tests with a tailwind project to the set-border-radius strategy test suite - removeTailwindClasses guarantees that subsequent tests do not have the tailwind css on **Todo:** - [x] Check why the ``ElementsToRerenderGLOBAL.current` check caused problems. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Make border-radius controls work in tailwind projects.
Fix:
ElementsToRerenderGLOBAL.current
has to be'rerender-all-elements'
for the tailwind classes to be regenerated. For some reason this blocked the class generation after a border-radius interaction. We are still protected against tailwind class generation during the interaction (we checkisInteractionActive
)Todo:
Manual Tests:
I hereby swear that: