Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If a part of a grid item's CSS includes a span value like
span 2
, then the pin outlines end up in unusual places.Cause:
When constructing the containing block which governs from where the outlines start and end, the grid column/row start/end properties are converted to simpler values using
gridPositionToValue
, which turnsspan 2
into2
.Fix:
Using some existing code for turning the position values into CSS values, the containing block bounds now result in the CSS values that they started with if those exist.
Commit Details:
printPin
function.nullHandlingPrintPin
as a thin wrapper aroundprintPin
.GridElementContainingBlock
now usesnullHandlingPrintPin
instead ofgridPositionToValue
to build the grid column/row start/end values.Manual Tests:
I hereby swear that: