-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwind aware padding #6637
Merged
Merged
Tailwind aware padding #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15132 Bundle Size — 58.08MiB (~+0.01%).79399a8(current) vs d1d46c1 master#15127(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch feature/tailwind-aware-padding Project dashboard Generated by RelativeCI Documentation Report issue |
Rheeseyb
approved these changes
Nov 14, 2024
seanparsons
approved these changes
Nov 15, 2024
seanparsons
pushed a commit
that referenced
this pull request
Nov 18, 2024
## Problem The padding controls cannot be used to read/write values in projects that use Tailwind for styling. ## Fix Use the style plugins and the `StyleInfo` system to make this possible. Specifically, - Add the padding shorthand prop/padding longhand prop to the `StyleInfo` interface - Update `InlineStylePlugin` and `TailwindStylePlugin` to support the new props in `StyleInfo` - Refactor the padding strategy, the padding control handle and the subdued padding control to read element styles through a `StyleInfoReader` instance - Add a new property patcher in `style-plugins@patchers` to take care of patching removed padding props - Add tests with a tailwind project to the padding strategy test suite ### Out of scope The jump in the bounding box after the interaction ends ([video](https://screenshot.click/14-02-e9ktf-say96.mp4)) will be addressed on a follow-up PR ### Manual Tests I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Problem The padding controls cannot be used to read/write values in projects that use Tailwind for styling. ## Fix Use the style plugins and the `StyleInfo` system to make this possible. Specifically, - Add the padding shorthand prop/padding longhand prop to the `StyleInfo` interface - Update `InlineStylePlugin` and `TailwindStylePlugin` to support the new props in `StyleInfo` - Refactor the padding strategy, the padding control handle and the subdued padding control to read element styles through a `StyleInfoReader` instance - Add a new property patcher in `style-plugins@patchers` to take care of patching removed padding props - Add tests with a tailwind project to the padding strategy test suite ### Out of scope The jump in the bounding box after the interaction ends ([video](https://screenshot.click/14-02-e9ktf-say96.mp4)) will be addressed on a follow-up PR ### Manual Tests I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The padding controls cannot be used to read/write values in projects that use Tailwind for styling.
Fix
Use the style plugins and the
StyleInfo
system to make this possible.Specifically,
StyleInfo
interfaceInlineStylePlugin
andTailwindStylePlugin
to support the new props inStyleInfo
StyleInfoReader
instancestyle-plugins@patchers
to take care of patching removed padding propsOut of scope
The jump in the bounding box after the interaction ends (video) will be addressed on a follow-up PR
Manual Tests
I hereby swear that: