Read style props through StyleInfo in AdjustCssLengthProperties
#6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15109 Bundle Size — 58.08MiB (~-0.01%).886103b(current) vs d1d46c1 master#15107(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15109 |
Baseline #15107 |
|
|---|---|---|
 Initial JS |
41.05MiB(~-0.01%) |
41.05MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.13% |
18.6% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4169 |
4169 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.3% |
27.3% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 improvements
| Current #15109 |
Baseline #15107 |
|
|---|---|---|
| JS |
58.07MiB (~-0.01%) |
58.07MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feature/tailwind-aware-commands Project dashboard
Generated by RelativeCI Documentation Report issue
bkrmendy
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
liady
bkrmendy
changed the title
AdjustCssLengthProperties style prop-agnosticStyleInfo in AdjustCssLengthProperties
seanparsons
reviewed
Nov 13, 2024
seanparsons
approved these changes
Nov 13, 2024
gbalint
approved these changes
Nov 13, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
…6632) ## Problem The padding strategy relies on the `AdjustCssLengthProperties` command to update elements, both for reading and writing styles. In order for that to work in Tailwind projects, where elements don't have an inline style prop, `AdjustCssLengthProperties` needs to read element styles from the "right" property, otherwise the command wouldn't work as intended. ## Fix Use the `StyleInfo` system from to read the element style info. ### Details - Refactored `AdjustCssLengthProperties` to read elements styles through `styleInfo` - Created a bespoke prop, `LengthProperty`, to track which props are addressed by `LengthPropertyToAdjust`. This way it's easy to tell which props need to be supported by `StyleInfo` to have `AdjustCssLengthProperties` working well - Extended `StyleInfo` to support the props read by `AdjustCssLengthProperties` - Updated the style plugins to support the new `StyleInfo` props ### Manual Tests: I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The padding strategy relies on the
AdjustCssLengthPropertiescommand to update elements, both for reading and writing styles. In order for that to work in Tailwind projects, where elements don't have an inline style prop,AdjustCssLengthPropertiesneeds to read element styles from the "right" property, otherwise the command wouldn't work as intended.Fix
Use the
StyleInfosystem from to read the element style info.Details
AdjustCssLengthPropertiesto read elements styles throughstyleInfoLengthProperty, to track which props are addressed byLengthPropertyToAdjust. This way it's easy to tell which props need to be supported byStyleInfoto haveAdjustCssLengthPropertiesworking wellStyleInfoto support the props read byAdjustCssLengthPropertiesStyleInfopropsManual Tests:
I hereby swear that: