more granular unparsable prop detection for StyleInfo
#6631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15096 Bundle Size — 58.06MiB (~+0.01%).f2db984(current) vs d1d46c1 master#15094(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15096 |
Baseline #15094 |
|
|---|---|---|
 Initial JS |
41.04MiB(~+0.01%) |
41.04MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.11% |
18% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4167 |
4167 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.3% |
27.3% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15096 |
Baseline #15094 |
|
|---|---|---|
| JS |
58.06MiB (~+0.01%) |
58.06MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feature/style-info-not-editable-... Project dashboard
Generated by RelativeCI Documentation Report issue
…to feature/style-info-not-editable-property
bkrmendy
changed the title
StyleInfoStyleInfo
bkrmendy
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
liady
seanparsons
approved these changes
Nov 11, 2024
gbalint
approved these changes
Nov 12, 2024
balazsbajorics
approved these changes
Nov 12, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Problem
The `StyleInfo` type doesn't express the state when a property is set,
but it cannot parsed in the desired format. For example, in `style={{
top: '300px', left: theme.left + 50 }}`, `top` can be parsed as a css
number, but left cannot be.
We need to be able to express this, since some code
(`AdjustCssLengthProperties` and `SetCSSLength` for example) need to
handle it. Once `AdjustCssLengthProperties` and `SetCSSLength` use this
infra, we can make more strategies Tailwind-compatible.
## Fix
Extend the `StyleInfo` type, and fix any affected code.
**Manual Tests:**
I hereby swear that:
- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
StyleInfotype doesn't express the state when a property is set, but it cannot parsed in the desired format. For example, instyle={{ top: '300px', left: theme.left + 50 }},topcan be parsed as a css number, but left cannot be.We need to be able to express this, since some code (
AdjustCssLengthPropertiesandSetCSSLengthfor example) need to handle it. OnceAdjustCssLengthPropertiesandSetCSSLengthuse this infra, we can make more strategies Tailwind-compatible.Fix
Extend the
StyleInfotype, and fix any affected code.Manual Tests:
I hereby swear that: