Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename grid cell to grid item #6623

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Rename grid cell to grid item #6623

merged 1 commit into from
Nov 7, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Nov 6, 2024

Problem:
Sometimes we call the grid items "grid cells", which is incorrect (grid cells are the positions in the grid, and not the child items).

Fix:
Rename

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Try me

Copy link

relativeci bot commented Nov 6, 2024

#15053 Bundle Size — 58.05MiB (~-0.01%).

579fa8a(current) vs d1d46c1 master#15043(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#15053
     Baseline
#15043
Regression  Initial JS 41.03MiB(~+0.01%) 41.03MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.09% 17.97%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4166 4166
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.31% 27.31%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#15053
     Baseline
#15043
Regression  JS 58.04MiB (~+0.01%) 58.04MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch chore/rename-gridcellProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@liady liady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌

@gbalint gbalint merged commit 3148367 into master Nov 7, 2024
17 checks passed
@gbalint gbalint deleted the chore/rename-gridcell branch November 7, 2024 09:44
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**
Sometimes we call the grid items "grid cells", which is incorrect (grid
cells are the positions in the grid, and not the child items).

**Fix:**
Rename

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants