Include border widths when measuring grid templates for controls #6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15052 Bundle Size — 58.05MiB (~+0.01%).4c4b0c4(current) vs d1d46c1 master#15043(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15052 |
Baseline #15043 |
|
|---|---|---|
 Initial JS |
41.03MiB(~+0.01%) |
41.03MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.09% |
17.97% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4166 |
4166 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.31% |
27.31% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15052 |
Baseline #15043 |
|
|---|---|---|
| JS |
58.04MiB (~+0.01%) |
58.04MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/grid-measurement-border Project dashboard
Generated by RelativeCI Documentation Report issue
bkrmendy
approved these changes
Nov 6, 2024
|
Instead of rendering the grid helper/control from the metadata, maybe we could just find the actual grid in the DOM and use its computed style to render the appropriate helper grid. It would be simpler (we don't have to save the style data in the metadata and then recreate that again in the control) and better too (now theoretically there is a frame delay before the control is updated, because we need to dom-walk the grid and store the results in the metadata first). WDYT? |
balazsbajorics
approved these changes
Nov 6, 2024
seanparsons
approved these changes
Nov 7, 2024
liady
approved these changes
Nov 7, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Border width is not taken into account when calculating grid template measurements, which results in the grid placeholders being misplaced. **Fix:** Include the border widths in the special size measurements and use them (transparent) for the grid placeholder styles. Fixes #6619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Border width is not taken into account when calculating grid template measurements, which results in the grid placeholders being misplaced.
Fix:
Include the border widths in the special size measurements and use them (transparent) for the grid placeholder styles.
Fixes #6619