Store render prop name in metadata

[Rheeseyb]

Problem
The new component insert menu needs to know if it is targeting a render prop (and which) in order to provide suitable options and to actually replace the target. This was fine when it was only invoked from the Navigator (as the navigator items included this information), but not when it is invoked from the canvas or keyboard shortcuts, as this information isn't readily available.

Fix
To get around this I have now introduced the name of the prop that the element is assigned to in its metadata as a string | null. We capture this by providing it to the spy wrapper at render time, and then look it up before showing the component picker via the keyboard shortcut or canvas context menu.

I appreciate that the name used here prop isn't great, so I'm open to alternatives there.

Fixes #5440

[github-actions]

Try me

[relativeci]

#12092 Bundle Size — 62.43MiB (+0.01%).

9d205ec(current) vs 6339ece master#12089(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics   3 changes 1 regression

	Current #12092	Baseline #12089
Initial JS	45.5MiB(+0.02%)	45.5MiB
Initial CSS	0B	0B
Cache Invalidation	21.7%	21%
Chunks	31	31
Assets	34	34
Modules	4375	4375
Duplicate Modules	504	504
Duplicate Code	30.83%(+0.03%)	30.82%
Packages	467	467
Duplicate Packages	58	58

Bundle size by type   2 changes 1 regression 1 improvement

	Current #12092	Baseline #12089
JS	62.42MiB (+0.01%)	62.41MiB
HTML	10.94KiB (-0.34%)	10.98KiB

---

Bundle analysis report Branch feature/render-prop-in-metadata Project dashboard

[github-actions]

Performance test results:

[gbalint]

I think prop is not a very helpful name, especially because a jsx element has props itself.
Can this be something more verbose and clear? E.g. containingRenderProp or something like that?

[Rheeseyb]

Yeah as mentioned I know the name is bad. I'm going to go with assignedToProp (or assignedToRenderProp perhaps) and see how that feels

[Rheeseyb]

Ok done - I went with assignedToProp. How do you feel about that?

[gbalint]

assignedToProp is fine by me!