Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI fixes for data picker #4924

Merged
merged 5 commits into from
Feb 21, 2024
Merged

UI fixes for data picker #4924

merged 5 commits into from
Feb 21, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Feb 19, 2024 •
edited
Loading

Implement UI fixes for data picker as mentioned here:
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 19, 2024 •
edited
Loading

Job #10508: Bundle Size — 62.17MiB (~+0.01%).

24102a2(current) vs d299c8d master#10503(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10508		      Baseline
Job #10503
Regression  Initial JS 35.21MiB(~+0.01%) 35.21MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.38% 20.36%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4360 4360
No change  Duplicate Modules 494 494
No change  Duplicate Code 30.8% 30.8%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10508		      Baseline
Job #10503
Regression  JS 62.16MiB (~+0.01%) 62.16MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10508 report View fix/picker-design branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@liady liady marked this pull request as ready for review February 20, 2024 16:00
@liady liady merged commit 99b7a97 into master Feb 21, 2024
16 checks passed
@liady liady deleted the fix/picker-design branch February 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@bkrmendy bkrmendy bkrmendy approved these changes

@gbalint gbalint Awaiting requested review from gbalint

@Rheeseyb Rheeseyb Awaiting requested review from Rheeseyb

@ruggi ruggi Awaiting requested review from ruggi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liady @balazsbajorics @bkrmendy