Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split grid move strategies #6607

Closed
ruggi opened this issue Oct 31, 2024 · 0 comments · Fixed by #6606
Closed

Split grid move strategies #6607

ruggi opened this issue Oct 31, 2024 · 0 comments · Fixed by #6606
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Oct 31, 2024

No description provided.

@ruggi ruggi self-assigned this Oct 31, 2024
@ruggi ruggi closed this as completed in bee47ee Nov 5, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**

The move strategies for grids should be split both functionally as well
as implementation-wise.

**Fix:**

This PR does a bunch of things in order to clean up the grid move
strategies:

- Remove the swap strategy
- Split the rearrange strategy into two distinct strategies: rearrange
and reorder
- Take out the absolute move portions out of the rearrange strategy into
their own strategy
- The reorder strategy performs in-flow moves
- The rearrange strategy performs pinned moves
- When the reorder strategy is active, don't show the animation as well
as the target cell outline
- For pinned elements, give precedence to the rearrange strategy
- For in-flow elements, give precedence to the reorder strategy
- Marked all usages of `EP.parentPath` to detect the parent grid as
`TODO` for a future PR fixing that in favor of actual grid metadata

**Note:**
Imho the tests should be also split in two, in this PR I only updated
the existing ones (which are still relevant tho!) but it'd be good to
have an incremental PR to do that split as well.


Fixes #6607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant