Split grid move strategies #6607
Assignees
Comments
liady
pushed a commit
that referenced
this issue
Dec 13, 2024
**Problem:** The move strategies for grids should be split both functionally as well as implementation-wise. **Fix:** This PR does a bunch of things in order to clean up the grid move strategies: - Remove the swap strategy - Split the rearrange strategy into two distinct strategies: rearrange and reorder - Take out the absolute move portions out of the rearrange strategy into their own strategy - The reorder strategy performs in-flow moves - The rearrange strategy performs pinned moves - When the reorder strategy is active, don't show the animation as well as the target cell outline - For pinned elements, give precedence to the rearrange strategy - For in-flow elements, give precedence to the reorder strategy - Marked all usages of `EP.parentPath` to detect the parent grid as `TODO` for a future PR fixing that in favor of actual grid metadata **Note:** Imho the tests should be also split in two, in this PR I only updated the existing ones (which are still relevant tho!) but it'd be good to have an incremental PR to do that split as well. Fixes #6607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: