-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpp_info.components first iteration #6653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like what I see 🙌 just really quick comments, don't take them seriously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Please have a look to the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Let's see if we can tackle those two comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 Great!
Docs needed
Added docs at conan-io/docs#1363 |
Changelog: Feature: Add
cpp_info.components
package creator interface to model internal dependencies inside a recipe.Docs: conan-io/docs#1363
This PR covers the following:
cpp_info.components
to define different "targets" at recipe creator leveldeps_cpp_info.components
is not available, all the info can be only consumed in a "global" or per dependency way taking into account the new info introduced by each component.cpp_info.release.components["name"]....
is allowed. This has been left for future consideration.Additional points after review:
cppinfo
improvements: components, exe, system deps... #5090, closes Feature: model intra-package dependencies #2387develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.