Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the message for client migration #17751

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

seppzer0
Copy link
Contributor

@seppzer0 seppzer0 commented Feb 11, 2025

Changelog: Fix: Update the message for client migration.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Fair note -- I did knowingly skip the discussion of this issue, because it subjectively seemed too trivial to discuss. Please let me know if you think otherwise.

In short, this is a simple fix of a string that gets shown in output when upgrading Conan version.
Additionally, a related f-string was converted into a regular string, since there's nothing to actually format for it.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @seppzer0

Could you please check and sign the CLA? If you already tried and it didn't work, it can happen if the commit is signed with a different email rather than the Github email.

@memsharded memsharded added this to the 2.13.0 milestone Feb 11, 2025
@seppzer0
Copy link
Contributor Author

@memsharded , hi
Checked and signed the CLA, should be fine now

@memsharded memsharded merged commit d8cadc2 into conan-io:develop2 Feb 11, 2025
34 checks passed
@memsharded
Copy link
Member

Merged, thanks!, it will be in next 2.13

@seppzer0 seppzer0 deleted the fix/update_migration_string branch February 11, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants