-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a repository parameter to coordinates_to_conandata(). #17722
Add a repository parameter to coordinates_to_conandata(). #17722
Conversation
This is a trivial change (simple forward), please let me know if that still requires adding tests? Also, I updated the function "preamble" with the parameter info, will the documentation be automatically reflect that, or should I update the docs repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I think this is so simple, we can move without a new test.
This https://docs.conan.io/2/reference/tools/scm/git.html#conan.tools.scm.git.Git.coordinates_to_conandata is automatically generated, it should show it automatically, no need for a PR to the docs, thanks.
Looking at the error in the CI builds, they are mostly of the form
The message is a bit surprising (mentioning |
Yeah, seems unrelated, maybe the develop2 build is broken, don't worry about it, we will fix it and update what is necessary and make it into the next release. Thanks very much again! |
Changelog: Feature: Forward repository parameter (with same default) from
coordinates_to_conandata()
toget_url_and_commit()
.Docs: Omit
fixes #17698
develop
branch, documenting this one.