Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repository parameter to coordinates_to_conandata(). #17722

Conversation

Adnn
Copy link
Contributor

@Adnn Adnn commented Feb 6, 2025

Changelog: Feature: Forward repository parameter (with same default) from coordinates_to_conandata() to get_url_and_commit().
Docs: Omit

fixes #17698

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@Adnn
Copy link
Contributor Author

Adnn commented Feb 6, 2025

This is a trivial change (simple forward), please let me know if that still requires adding tests?

Also, I updated the function "preamble" with the parameter info, will the documentation be automatically reflect that, or should I update the docs repo?

@memsharded memsharded self-assigned this Feb 6, 2025
@memsharded memsharded added this to the 2.13.0 milestone Feb 6, 2025
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I think this is so simple, we can move without a new test.

This https://docs.conan.io/2/reference/tools/scm/git.html#conan.tools.scm.git.Git.coordinates_to_conandata is automatically generated, it should show it automatically, no need for a PR to the docs, thanks.

@Adnn
Copy link
Contributor Author

Adnn commented Feb 7, 2025

Looking at the error in the CI builds, they are mostly of the form

E -------- Preparing artifacts for upload --------
E ERROR: Package pkg/0.1 contains conandata scm url=C:/Users/runneradmin/AppData/Local/Temp/tmp8vyzqobbconans/path with spaces
E This isn't a remote URL, the build won't be reproducible
E Failing because conf 'core.scm:local_url!=allow'

The message is a bit surprising (mentioning with spaces where the url seems not to contain any), and seems related to the config disallowing local URLs. I suppose this is not related to the change introduced by forwarding the repository argument.

@memsharded
Copy link
Member

Yeah, seems unrelated, maybe the develop2 build is broken, don't worry about it, we will fix it and update what is necessary and make it into the next release. Thanks very much again!

@memsharded memsharded merged commit c156378 into conan-io:develop2 Feb 7, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Git.coordinates_to_conandata() is missing the repository argument.
4 participants