-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Why are version rangers not allowed? #8831
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Updating docs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you very much!
Good to have this in the docs for sure! What does package version mean in "may resolve to a different package version"? If it's just version in the sense that the binary might be slightly different maybe a different phrase would be clearer. If it's about generated metadata e.g. package id, would build requirement versions affect that? If not, a different justification is required for prohibiting version ranges for e.g. CMake. |
a range like |
It's really the version of the dependency you are trying to add. It's a superficial comment (from my lack of expertise)
That's an excellent question! I have no idea 😄 peaking at th docs its not obvious whats the affect on the UPDATE: After some digging I found this conan-io/conan#8504 (comment)
I think it's more clear in Conan V2, https://docs.conan.io/en/latest/devtools/build_requires.html?highlight=package_id The old |
Reproducibility and compatibility is a good reason to avoid version ranges in CCI, but not the only one. In fact, even if we fix a version, we still are using different recipe revisions when they are available... reproducibility is not possible without using lockfiles. Another reason is the default package-id mode. It takes into account the major version of the requirements. With version ranges someone could declare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, this is a good note, we can improve it in the future 👍
* Why are version rangers not allowed * fix up some typos I noticed while scrolling * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Docs!
I noticed this in some recent PR and was not able to find it documented. I was not able to find the pass conversations (we make too many PRs - good problems) so I went off memory.
Feedback welcomed!