sentry-crashpad: add sentry-crashpad recipe

[madebr]

The versions are the same as the one in sentry-native.

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[SpaceIm]

I don't really understand why a new recipe is required. It's sentry-native with vendored crashpad, correct? It could live in #5524.

[madebr]

I don't really understand why a new recipe is required. It's sentry-native with vendored crashpad, correct? It could live in #5524.

Modularity.
This allows switching out sentry's forked crashpad with the original crashpad at #5511.

[prince-chrismc]

Do we still need this since the other two related PRs were merged?

[madebr]

This fork provides features that the original does not, such as attachments.

[jgsogo]

I'm the third person asking the same... 😅

This recipe is downloading the same sources as sentry-native, why not adding an option to that recipe to switch behavior?

[madebr]

It makes more sense.

The unix philosophy is to let something do one and only one thing. Don't complicate things by mixing.
sentry-crashpad can be used standalone, without sentry-native.
The code will get messier when we need to mix the validate logic for sentry-native and crashpad.
The crashpad fork is developed in a separate repo (https://github.com/getsentry/crashpad/) and is only copied into sentry-native for releases. So in a sense it is treated as a separate project by sentry already.

The downside is that every sentry-native release requires a sentry-crashpad release.

Extra reason to add it as a separate recipe:
breakpad is another external dependency of sentry-native with its own requirements.
This adds even more complications.

[MartinDelille]

We will need the qt option added here then: #5440

[madebr]

We will need the qt option added here then: #5440

Why's that?
I just did a grep for qt in the source folder of the 0.4.9 release and could only find a match in CMakeLists.txt and src/CMakeLists.txt.
Not in external/crashpad.

Sorry, I misunderstood.

Yes, the sentry-native recipe will need an extra option: "with_crashpad": ["google", "sentry"] (only used when self.options.backend == "crashpad").

[uilianries]

Suggested change

	handler_exe = "crashpad_handler.exe" if self.settings.os == "Windows" else "crashpad_handler"
	handler_bin_path = os.path.join(self.deps_cpp_info["sentry-crashpad"].rootpath, "bin", handler_exe)
	handler_exe = "crashpad_handler.exe" if self.settings.os == "Windows" else "crashpad_handler"
	handler_bin_path = os.path.join(self.deps_cpp_info["sentry-crashpad"].rootpath, "bin", handler_exe)

You don't need to pass the absolute path. By run_environment, it's already included in PATH, and with priority order, so even if there is another app with same name, that one provided by Conan should be used first.

[madebr]

The absolute path is passed as an argument.
When applying the following patch:

diff --git a/recipes/sentry-crashpad/all/test_package/conanfile.py b/recipes/sentry-crashpad/all/test_package/conanfile.py
index 724a4675..1b6e6555 100644
--- a/recipes/sentry-crashpad/all/test_package/conanfile.py
+++ b/recipes/sentry-crashpad/all/test_package/conanfile.py
@@ -16,6 +16,5 @@ class TestPackageConan(ConanFile):
             test_env_dir = "test_env"
             tools.mkdir(test_env_dir)
             bin_path = os.path.join("bin", "test_package")
-            handler_exe = "crashpad_handler.exe" if self.settings.os == "Windows" else "crashpad_handler"
-            handler_bin_path = os.path.join(self.deps_cpp_info["sentry-crashpad"].rootpath, "bin", handler_exe)
-            self.run("%s %s/db %s" % (bin_path, test_env_dir, handler_bin_path), run_environment=True)
+            handler_exe = "crashpad_handler.exe" if self.settings.os == "Windows" else "crashpad_handler"e)
+            self.run("%s %s/db %s" % (bin_path, test_env_dir, handler_exe), run_environment=True)

the following error occurs:

----Running------
> bin/test_package test_env/db crashpad_handler
-----------------
[23258:23258:20210527,173156.407616:FATAL double_fork_and_exec.cc:131] execv crashpad_handler: No such file or directory (2)

[ericriff]

Why pulling sentry-native instead of just the submodule?
https://github.com/getsentry/crashpad
Is it because of the tags/releases?

[madebr]

That repo does no releases and has no stable branches.
They rebase on top of google crashpad's master.

[ericriff]

Why do you condition openssl requirement with an option?
According to the sources it will always look for it on Linux and Android. It could end up picking up the system instal of if this option is set to false.
https://github.com/getsentry/crashpad/blob/getsentry/CMakeLists.txt#L27

[madebr]

Fixed it.
By patching the cmake script, it can be kept as an option.

[ericriff]

Why changing the default behavior with an option?

[SpaceIm]

because default behavior is bad, unpredictable.

For package managers:
bad build system design: try to find a dependency and disable a feature if not found
good build system design: enable an option, hard fail if requirements for this option are not met

[ericriff]

Strong argument haha

[madebr]

Indeed, that's the reason.

I think openssl is only used by the crashpad_handler executable. Not by the library.

[conan-center-bot]

All green in build 10 (2f936f825157709c623a0a030a7c5061adededbe):

• sentry-crashpad/0.4.9@:
  All packages built successfully! (All logs)

• sentry-crashpad/0.4.8@:
  All packages built successfully! (All logs)

• sentry-crashpad/0.4.7@:
  All packages built successfully! (All logs)

• sentry-crashpad/0.2.6@:
  All packages built successfully! (All logs)

• sentry-crashpad/0.4.1@:
  All packages built successfully! (All logs)