Add openscenegraph/3.6.5 #2702
Merged
Add openscenegraph/3.6.5 #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure in build 1 (
|
|
OpenSceneGraph is designed heavily around being dynamic and using plugins to load various functionality. While it can be built as a static library, most software out there expects it to be built as a shared library (and will break if OSG is not a shared library). I think this is a case that shared=True should be the default. |
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
SpaceIm
reviewed
Aug 28, 2020
|
Some configurations of 'openscenegraph/3.6.5' failed in build 3 (
|
SpaceIm
reviewed
Aug 31, 2020
|
Some configurations of 'openscenegraph/3.6.5' failed in build 5 (
|
this insures consistency across CMake generators
ohanar
force-pushed
the
openscenegraph
branch
from
4f7a625 to
97bece4
Compare
|
Some configurations of 'openscenegraph/3.6.5' failed in build 10 (
|
|
I'm having a look to this PR, it takes too long to compile and I think the CI is reporting as failures some internal errors. I need to check. |
|
@jgsogo The latest logs look like genuine failures, but yes it does take a while to build. |
For whatever reason, osgz support fails on linux when built dynamically.
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
|
Some configurations of 'openscenegraph/3.6.5' failed in build 12 (
|
prince-chrismc
previously approved these changes
Dec 2, 2020
jgsogo
reviewed
Dec 2, 2020
There was a problem hiding this comment.
IMO, this is ready to go with those two changes proposed by @prince-chrismc
🎉
|
As mentioned in the nest of comments, #2702 (comment) the extra checks for the version are required it's just the |
jgsogo
reviewed
Dec 2, 2020
danimtb
previously approved these changes
Dec 9, 2020
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
|
Some configurations of 'openscenegraph/3.6.5' failed in build 33 (
|
|
Okay, had a busy December, just found a bit of time to address the handful of minor issues that came up during the last round of reviews. |
prince-chrismc
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
This is a massive PR and I think we should merge it in and address the comments in a subsequent PR...
It's at the point I suspect some details of what we expect have changed since this has been open so long!
Overall I think it's complete, just some nit-picking comments to add
🚀 Merge!
Comment on lines
+123
to
+124
| # if self.options.with_collada: | ||
| # self.requires("libxml2/2.9.10") |
There was a problem hiding this comment.
I believe we have a preference for adding the option and throwing invalid configuration (the idea is to have consistent package_id as more options are supported)
Comment on lines
+239
to
+242
| for pdb in glob.iglob(os.path.join(self.package_folder, "bin", "*.pdb")): | ||
| os.unlink(pdb) | ||
| for pdb in glob.iglob(os.path.join(self.package_folder, "bin", "osgPlugins-{}".format(self.version), "*.pdb")): | ||
| os.unlink(pdb) |
There was a problem hiding this comment.
in 1.29.1 conan gained tools.remove_by_mask
| from conans import CMake, ConanFile, tools | ||
| import glob, os | ||
|
|
||
|
|
There was a problem hiding this comment.
Since you are using components
Suggested change
| required_conan_version = ">=1.28.0" | |
|
@prince-chrismc Should I open a second PR to address your feedback? I also need to update a lot of the dependencies. |
|
This should be merged first. 🤔 You need to retrigger CI to get a build... or else it will be closed from going stale.. Once a build passes you'll get more reviews |
|
All green in build 35 (
|
SSE4
approved these changes
Jan 16, 2021
danimtb
approved these changes
Jan 18, 2021
SpaceIm
approved these changes
Jan 18, 2021
jgsogo
dismissed
memsharded’s stale review
Recipe is no longer using hihgly-experimental 'toolchain' method. Need to dismiss in order to unblock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: openscenegraph/3.6.5
Closes #171
conan-center hook activated.