Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite3 3.31.1 + build CLI #1004

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Sqlite3 3.31.1 + build CLI #1004

merged 3 commits into from
Mar 12, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 29, 2020

Specify library name and version: sqlite3/3.31.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (72dc38d7967aafbfcb3c89a929aa7cc750c6ea1c)! 😊

SSE4
SSE4 previously approved these changes Mar 2, 2020
View reviewed changes
@SSE4 SSE4 requested a review from uilianries March 2, 2020 10:33
uilianries
uilianries requested changes Mar 2, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to append bin folder to the PATH

@SpaceIm @uilianries
sqlite3: add CLI folder to PATH
c7cfcbe 
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@SpaceIm SpaceIm requested review from uilianries and SSE4 March 2, 2020 15:18
@conan-center-bot
Copy link
Collaborator

All green in build 2 (c7cfcbe3e465b2892d647e197da17db454b62f9c)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 3 (c7cfcbe3e465b2892d647e197da17db454b62f9c)! 😊

@SpaceIm SpaceIm mentioned this pull request Mar 12, 2020
Closed
4 tasks
danimtb
danimtb approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 Thanks a lot for this @SpaceIm!

@danimtb danimtb self-assigned this Mar 12, 2020
@danimtb danimtb merged commit 89c0326 into conan-io:master Mar 12, 2020
@SpaceIm SpaceIm deleted the sqlite3-3.31.1 branch March 12, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @SSE4 @uilianries @danimtb