Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus PVE Exporter: Rightsizing RAM and Disk #3098

Conversation

andygrunwald
Copy link
Contributor

✍️ Description

This PR is rightsizing the Prometheus PVE Exporter resources RAM and Disk.

🔗 Related PR / Discussion / Issue

None

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • [] 🆕 New script – A fully functional and tested script or script set.
  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • [] ✨ New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.

📋 Additional Information (optional)

Screenshot 2025-03-15 at 13 14 42 Screenshot 2025-03-15 at 13 13 28

@andygrunwald andygrunwald requested a review from a team as a code owner March 15, 2025 12:16
@github-actions github-actions bot added json update script A change that updates a script website A change to the website labels Mar 15, 2025
Copy link
Contributor

⚠️ The script ct/prometheus-pve-exporter.sh failed with the following message:


Failure in line 24 while executing command 'apt-get install -y python3 python3-pip'

@michelroegl-brunner
Copy link
Member

You are sure 128MB of Ram are enough so that the install dose not take ages?

@CrazyWolf13
Copy link
Contributor

agreed, 128MB seems too low, I'd rather go with 512 at minimum, if someone really is that low on RAM, one can manually change it later on.

About the disk, thanks!

@MickLesk
Copy link
Member

MickLesk commented Mar 15, 2025

I can live with 512. Less only for alpine.
Its just an "Maximum", the LXC Take what it need

@andygrunwald
Copy link
Contributor Author

You are sure 128MB of Ram are enough so that the install dose not take ages?

It was not known to me that install speed is a metric that is taken into account in this project. For me, this metric is less relevant as installation is a one time action.

I set the RAM to 512, as this seem to be the outcome of the discussion.

@tremor021 tremor021 merged commit 08e0a63 into community-scripts:main Mar 16, 2025
5 checks passed
@tremor021
Copy link
Member

Ultimately it doesnt really matter unless you're installing some really RAM hungry app. 512MB is a good measure here, you really cant tell if the app gets stupid and spikes RAM usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
json update script A change that updates a script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants