Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merges fixes, features and refactors for version 0.5.2 #7

Merged
merged 9 commits into from
Feb 15, 2025
Merged

Conversation

pjox
Copy link
Member

@pjox pjox commented Feb 14, 2025

Description

This PR

  • Fixes issue feat: Add a User Agent to cc-downloader #6
  • Introduces refactors so that linter check are all passed
  • Introduces a rust workflow for ensuring that the code compiles and test are passed in the dev and main branches
  • Introduces changes to the contributing policy so that PRs are merged to the dev branch
  • Introduces slight updates to the documentation

Breaking Changes

There are no breaking changes for this PR.

Notes & open questions

This PR starts organizing the download.rs file so that cc-downloader can also be used as a library and so that bindings can be more easily written.

No questions are open with this PR.

pjox added 9 commits February 4, 2025 18:10
This commit adds a User Agent to cc-downloader so that its use can better be tracked.
It adds a refactor to the way the client is built so that the code is reused by both the download-paths and download functions.
It also adds 2 tests to check that the user agent is properly set.
feat: Add a User Agent to cc-downloader

This PR also adds test to ensure the User Agent is properly set up
This commit adds a simple GitHub action that ensures that the code compiles and that all tests are passsed
…hecks

This commit also prepares the code to be used as a library and to make bindings from it.
@pjox pjox added bug Something isn't working enhancement New feature or request labels Feb 14, 2025
@pjox pjox requested a review from thunderpoot February 14, 2025 18:56
@pjox pjox self-assigned this Feb 14, 2025
@pjox pjox linked an issue Feb 14, 2025 that may be closed by this pull request
Copy link
Member

@thunderpoot thunderpoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pjox pjox changed the title chore: Mergers fixes, features and refactors for version 0.5.2 chore: Merges fixes, features and refactors for version 0.5.2 Feb 15, 2025
@pjox pjox merged commit e2cd0e0 into main Feb 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a User-Agent to cc-downloader
2 participants