Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'symbolize' #7693

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Qqwy
Copy link
Contributor

@Qqwy Qqwy commented Feb 22, 2025

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

The Symbolize library has been rewritten, it now only contains dependencies that are already on Stackage and should work with a wider range of dependency bounds. As such, the time to add it to Stackage is here!

@Qqwy
Copy link
Contributor Author

Qqwy commented Feb 22, 2025

Ah, nice to see that the CI is now running for me without manual approval. (I cannot seem to get verify-package to run locally; it responds with 'Forbidden: access denied' errors from S3 for some reason?)

I will widen the dependency bounds further to work with the latest Stackage nightly.

@Qqwy
Copy link
Contributor Author

Qqwy commented Feb 22, 2025

Done!

CI now only fails on:


microlens-0.4.14.0 ([changelog](http://hackage.haskell.org/package/microlens-0.4.14.0/changelog)) (Steven Fontanella <steven.fontanella@gmail.com> @stevenfontanella) is out of bounds for:
- [ ] vty-6.2 (< 0.4.14). Grandfathered dependencies. Used by: library

which seems to be a problem in a different library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant