Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archetype Icon doesn't show it #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

macagua
Copy link
Member

@macagua macagua commented Oct 19, 2013

Previously I report a issue #9 with this pull request, I propose a solution.

@mauritsvanrees
Copy link
Member

I am against merging this. You are seeing this on Plone 3, right? The master branch of PloneSoftwareCenter is for Plone 4.0 and higher. Those Plone versions all have the png versions of these files. (The .gif files are also still there, though on Plone 4.3 you need to add plone_deprecated to the skin layer selection in portal_skins.)

@macagua
Copy link
Member Author

macagua commented Oct 21, 2013

@mauritsvanrees I agree with you, I did a pull request initially replace the extesion of the images from .gif to .png, this was discussed with @aclark4life via IRC chat and he suggested the addition of the images .gif and so I did.

I use Plone 4.3.2 with Python 2.7 on Linux

@macagua
Copy link
Member Author

macagua commented Oct 21, 2013

@mauritsvanrees How work this plone_deprecated to the skin layer ????

@mauritsvanrees
Copy link
Member

@macagua In the Zope Management Interface, go to portal_skins, then the Properties tab, and add plone_deprecated to the list of layers in the shown themes (like Sunburst Theme and Plone Default).

@macagua
Copy link
Member Author

macagua commented Jan 15, 2014

@mauritsvanrees then is necessary I add a skins.xml file to this package that defines "plone_deprecated" something like:

<?xml version="1.0"?>
<object name="portal_skins" meta_type="Plone Skins Tool" allow_any="False"
   cookie_persistence="False" default_skin="Sunburst Theme"
   request_varname="plone_skin">
 ...
 <object name="plone_deprecated" meta_type="Filesystem Directory View"
    directory="Products.CMFPlone:skins/plone_deprecated"/>

 <skin-path name="Plone Classic Theme">
  <layer name="plone_deprecated"/>
 </skin-path>

 <skin-path name="Plone Default">
  <layer name="plone_deprecated"/>
 </skin-path>

 <skin-path name="Sunburst Theme">
  <layer name="plone_deprecated"/>
 </skin-path>

</object>

I hope can help me to resolve this issue :)

@mauritsvanrees
Copy link
Member

That would work.

But I think I have not been clear. The point is that the master branch of Products.PloneSoftwareCenter is for Plone 4.0 and higher. Those Plone versions all have the .png files.

Ah, but I misjudged this. I somehow thought PloneSoftwareCenter was already using .png files. Well, it does for a few, but not all. The best would be to change the code so it uses .png images instead of .gif if the .png ones are available in Plone 4.0+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants