-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing quote around set arguments in bat #279
Conversation
6c6b0e2
to
b16ecfe
Compare
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 79.94% 79.94%
=======================================
Files 54 54
Lines 3141 3141
Branches 521 521
=======================================
Hits 2511 2511
Misses 589 589
Partials 41 41
Continue to review full report at Codecov.
|
Not just yet, getting: if "%PYTHONPATH:~-1%"==";" set "PYTHONPATH=%PYTHONPATH:~0,-1%"
'if' is not recognized as an internal or external command,
operable program or batch file. with these changes. |
3e77689
to
5d1af57
Compare
@hidmic Please try again with the updated patch. |
Approval under the assumption this fixes things (I haven't given it a try yet). |
I can wait for that - for this part it's better to double/triple check 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Testing in a small workspace of a few packages, it sets and strips the semi-colcon from CMAKE_PREFIX_PATH
and AMENT_PREFIX_PATH
correctly.
Took me a while to get back to this, but I can confirm the patch works just fine. Thanks! |
No description provided.