Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing quote around set arguments in bat #279

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

dirk-thomas
Copy link
Member

No description provided.

@dirk-thomas dirk-thomas added the bug Something isn't working label Dec 9, 2019
@dirk-thomas dirk-thomas self-assigned this Dec 9, 2019
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/fix-bat-quote branch from 6c6b0e2 to b16ecfe Compare December 9, 2019 21:29
@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   79.94%   79.94%           
=======================================
  Files          54       54           
  Lines        3141     3141           
  Branches      521      521           
=======================================
  Hits         2511     2511           
  Misses        589      589           
  Partials       41       41
Impacted Files Coverage Δ
colcon_core/shell/bat.py 93.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a06f55...5d1af57. Read the comment docs.

@hidmic
Copy link

hidmic commented Dec 9, 2019

Not just yet, getting:

if "%PYTHONPATH:~-1%"==";" set "PYTHONPATH=%PYTHONPATH:~0,-1%"
'if' is not recognized as an internal or external command,
operable program or batch file.

with these changes.

@dirk-thomas dirk-thomas force-pushed the dirk-thomas/fix-bat-quote branch from 3e77689 to 5d1af57 Compare December 10, 2019 04:54
@dirk-thomas
Copy link
Member Author

@hidmic Please try again with the updated patch.

@jacobperron
Copy link
Contributor

Approval under the assumption this fixes things (I haven't given it a try yet).

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Dec 10, 2019

I haven't given it a try yet.

I can wait for that - for this part it's better to double/triple check 😉

Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Testing in a small workspace of a few packages, it sets and strips the semi-colcon from CMAKE_PREFIX_PATH and AMENT_PREFIX_PATH correctly.

@dirk-thomas dirk-thomas added this to the 0.4.5 milestone Dec 10, 2019
@dirk-thomas dirk-thomas merged commit e1a1029 into master Dec 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-bat-quote branch December 10, 2019 18:58
@hidmic
Copy link

hidmic commented Dec 10, 2019

Took me a while to get back to this, but I can confirm the patch works just fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

4 participants