Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storage, statefulsyncer, and utils #99

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 17, 2020

Initially intended only for internal use, these packages have become useful to projects in the Rosetta ecosystem. It seemed strange that using them required referencing the rosetta-cli, so we are moving them to rosetta-sdk-go.

Changes

  • Move the storage, statefulsyncer, and utils package to rosetta-sdk-go

Future PR

  • Remove corresponding packages from rosetta-cli
  • Remove the rosetta-cli/logger dependency in rosetta-sdk-go

go.mod Outdated
github.com/btcsuite/btcd v0.20.1-beta
github.com/cenkalti/backoff v2.2.1+incompatible
github.com/coinbase/rosetta-cli v0.4.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove in follow-up PR

@coveralls
Copy link

coveralls commented Aug 17, 2020

Pull Request Test Coverage Report for Build 3873

  • 1155 of 1659 (69.62%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.1%) to 75.806%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage/utils.go 21 25 84.0%
storage/counter_storage.go 32 40 80.0%
storage/badger_storage.go 143 171 83.63%
storage/key_storage.go 88 125 70.4%
utils/utils.go 76 148 51.35%
storage/coin_storage.go 169 246 68.7%
storage/balance_storage.go 203 284 71.48%
storage/broadcast_storage.go 196 277 70.76%
storage/block_storage.go 227 343 66.18%
Totals Coverage Status
Change from base Build 3848: -3.1%
Covered Lines: 3760
Relevant Lines: 4960

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants