Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rosetta-cli dependency #100

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Remove rosetta-cli dependency #100

merged 2 commits into from
Aug 17, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 17, 2020 •
edited
Loading

This PR removes the need to import rosetta-cli. It was a fast-follow on the "move" PR.

Related PR: #99

Changes

  • Create new Logger interface in the statefulsyncer

juliankoh
juliankoh previously approved these changes Aug 17, 2020
View reviewed changes
@coveralls
Copy link

coveralls commented Aug 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 3904

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.806%
Totals Coverage Status
Change from base Build 3881: 0.0%
Covered Lines: 3760
Relevant Lines: 4960
💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 3bfd3f9 into master Aug 17, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/remove-cli-dependency branch August 17, 2020 18:40
@patrick-ogrady patrick-ogrady mentioned this pull request Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliankoh juliankoh juliankoh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @juliankoh