Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track OperationGroup Currencies #23

Merged
merged 2 commits into from
May 12, 2020
Merged

Track OperationGroup Currencies #23

merged 2 commits into from
May 12, 2020

Conversation

patrick-ogrady
Copy link
Contributor

Motivation

When parsing an OperationGroup it is often useful to know which currencies were present and if there were any operations with op.Amount == nil.

Solution

OperationGroup now has a slice of *types.Currency that contains all currencies present in an OperationGroup and a boolean indicating if any operation has a nil Amount.

@patrick-ogrady patrick-ogrady changed the title Store OperationGroup Currencies Track OperationGroup Currencies May 12, 2020
@patrick-ogrady patrick-ogrady added the enhancement New feature or request label May 12, 2020
@patrick-ogrady patrick-ogrady merged commit 740a957 into master May 12, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/operationGroupCurrencies branch May 12, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annieke annieke annieke approved these changes

@niallo niallo Awaiting requested review from niallo

@brockmiller brockmiller Awaiting requested review from brockmiller

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-ogrady @annieke