Update go/ethereum to v1.15.5 #145
Merged
+290
−767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rafalio-cb
commented
Mar 5, 2025
rafalio-cb
commented
- Updates to newest go/ethereum v1.15.5
- Since it pulls newer go, I will release this as v0.1.0, up from 0.0.22
✅ Heimdall Review Status
|
rafalio-cb
commented
Mar 5, 2025
| @@ -601,20 +603,18 @@ func FlattenTraces(data *Call, flattened []*FlatCall) []*FlatCall { | |||
| // https://github.com/ethereum/go-ethereum/blob/master/consensus/ethash/consensus.go#L646-L653 | |||
| func (ec *SDKClient) miningReward( | |||
| currentBlock *big.Int, | |||
| ) int64 { | |||
| ) *uint256.Int { | |||
There was a problem hiding this comment.
Making this a uint256 like the newest version of go-ethereum , they switched internally everything to it, @xiaying-peng
rafalio-cb
commented
Mar 5, 2025
| @@ -624,7 +624,7 @@ func (ec *SDKClient) BlockRewardTransaction( | |||
| uncles []*EthTypes.Header, | |||
| ) *RosettaTypes.Transaction { | |||
| var ops []*RosettaTypes.Operation | |||
| miningReward := ec.miningReward(big.NewInt(blockIdentifier.Index)) | |||
| miningReward := ec.miningReward(big.NewInt(blockIdentifier.Index)).Uint64() | |||
There was a problem hiding this comment.
afaik this will be totally fine here, and i dont' want to go adn update everything to 256 just to bring in the new go/ethereum version
rafalio-cb
changed the title
potterbm-cb
approved these changes
Mar 5, 2025
rafalio-cb
commented
Mar 5, 2025
| - RepoNotEmpty | ||
| - Brakeman | ||
| - BundleAudit | ||
| # - Gosec |
There was a problem hiding this comment.
This was necessary as it seems broken for any recent (go >= 1.23) go version, where it's required to have the go verison listed as 1.X.Y including minor, and these parsers fail to parse that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.