Merge pull request #95 from gregwym/greg/shutdown-log

Log shutdown progress for activity and workflow pollers
coinbase · Feb 19, 2025 · e7dbe2e · e7dbe2e
2 parents 93c17bf + 1544f2d
commit e7dbe2e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.1.28
+- Log shutdown progress for activity and workflow pollers
+- Add WorkflowAlreadyCompletingError to the rbi file
+- Validate that a workflow isn't completed before recording commands
+- Ruby 3 compatibility
+
 ## 0.1.21
 - Add workflow id and activity id to workflow and activity logs
 

diff --git a/lib/cadence/activity/poller.rb b/lib/cadence/activity/poller.rb
@@ -33,7 +33,9 @@ def stop
 
       def wait
         thread.join
+        Cadence.logger.info('Draining activity worker job queue')
         thread_pool.shutdown
+        Cadence.logger.info('Activity poller shutdown gracefully')
       end
 
       private

diff --git a/lib/cadence/version.rb b/lib/cadence/version.rb
@@ -1,3 +1,3 @@
 module Cadence
-  VERSION = '0.1.21'.freeze
+  VERSION = '0.1.28'.freeze
 end
diff --git a/lib/cadence/workflow/poller.rb b/lib/cadence/workflow/poller.rb
@@ -29,12 +29,14 @@ def start
 
       def stop
         @shutting_down = true
-        Cadence.logger.info('Shutting down a workflow poller')
+        Cadence.logger.info('Shutting down workflow poller')
       end
 
       def wait
         @thread.join
+        Cadence.logger.info('Draining workflow worker job queue')
         thread_pool.shutdown
+        Cadence.logger.info('Workflow poller shutdown gracefully')
       end
 
       private