Add coil-video to support decoding video frames. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
force-pushed
the
colin/video
branch
3 times, most recently
from
652563e to
0f9a2c9
Compare
colinrtwhite
force-pushed
the
colin/video
branch
6 times, most recently
from
06bca99 to
e306f14
Compare
colinrtwhite
force-pushed
the
colin/video
branch
from
14303de to
b143800
Compare
rafsanjani
approved these changes
Dec 26, 2019
colinrtwhite
force-pushed
the
colin/video
branch
3 times, most recently
from
0640b2d to
f8926bb
Compare
colinrtwhite
force-pushed
the
colin/video
branch
2 times, most recently
from
2333c45 to
e7bde45
Compare
colinrtwhite
force-pushed
the
colin/video
branch
4 times, most recently
from
76d612d to
28cfbd6
Compare
colinrtwhite
force-pushed
the
colin/video
branch
from
8b74a6b to
0e30005
Compare
colinrtwhite
force-pushed
the
colin/video
branch
from
0e30005 to
731dc1c
Compare
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Add coil-video to support decoding video frames. * Documentation. * Depend on updated Parameters API. * Add README. * Refactor extension functions. * Guard. * Use regular Dokka plugin. * Update docs and sample. * Formatting. * Fix clashing name. * Close the source. * Optimize. * Correctly close the source. * Optimization. * Remove operator. * Move FakeBitmapPool out of sharedTest. * Move sharedTest to coil-test module. * Add shell test class. * Add basic tests. * Support allowRgb565. * Support setting the video frame option. * Fix check. * Re-arrange. * Re-arrange. * WIP BufferedMediaDataSource rework. * Convert VideoFrameDecoder to a Fetcher. * Handle asset uris properly. * Use extension function. * Fix tests. * Documentation. * Documentation. * Fix imports. * Add to sample. * WIP * Ensure bitmap attributes. * First pass. * Fix Dokka. * Docs. * WIP. * Correctly calculate isSampled. * Clean up. * Guard against hardware config. * Rename asset. * Docs. * Rebase fix. * Use extension function. * Re-arrange. * Re-arrange. * Fix package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the state of this PR?
MediaMetadataRetrieverrequires the ability to read forward/backwards anywhere in the video file. For large video files this isn't feasible to buffer into memory. Also, we can't rely on having a backing file. This isn't feasible to add to Coil since theDecoderintentionally has no knowledge of the backing data source.If you have an idea of how to implement this with no breaking changes please let me know (or comment on this PR)!Support for this will arrive in
0.10.Fixes #25.