Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application restart is slow #96

Closed
cbxp opened this issue Dec 12, 2024 · 2 comments
Closed

Application restart is slow #96

cbxp opened this issue Dec 12, 2024 · 2 comments
Milestone
1.6.10

Comments

@cbxp
Copy link
Collaborator

cbxp commented Dec 12, 2024

During development, we often need to restart the application.
But every restart takes 3+ seconds.

It's caused by default value gracefulStopDelaySec=3 in klite.Server.start().

I assume this could be timeout (maximum time, up to 3 seconds).
But the application always waits for 3 seconds, even if there is not running requests/jobs.
@angryziber
Copy link
Member

This seems to be a bug in JDK HttpServer (ServerImpl), which according to the javadoc could terminate earlier, but in reality always waits as long as the passed delay...

angryziber added a commit that referenced this issue Dec 13, 2024
@angryziber
#96 make development and test restarts quicker
b7499ef
angryziber added a commit that referenced this issue Dec 13, 2024
@angryziber
#96 stop immediately if there are no known running requests (workarou…
6b9e31d 
…nd for a bug in JDK HttpServer, which waits in any case)
@angryziber
Copy link
Member

Improved idle restart in latest main

@angryziber angryziber added this to the 1.6.10 milestone Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.10
Development

No branches or pull requests
2 participants
@angryziber @cbxp