Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): prevent overwriting report artifacts #979

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Mar 11, 2025

Fixes #946

All output files are now immediately copied to a special .code-pushup/.ci folder, to prevent command outputs conflicting with artifact files.

CI output files structure

standalone - push

.code-pushup/
├─ .ci/
│  ├─ .current/
│  │  ├─ report.json
│  │  ├─ report.md

standalone - pull request

.code-pushup/
├─ .ci/
│  ├─ .comparison/
│  │  ├─ report-diff.json
│  │  ├─ report-diff.md
│  ├─ .current/
│  │  ├─ report.json
│  │  ├─ report.md
│  ├─ .previous/
│  │  ├─ report.json
│  │  ├─ report.md # if cache not used

monorepo - push

.code-pushup/
├─ .ci/
│  ├─ <project-name>/
│  │  ├─ .current/
│  │  │  ├─ report.json
│  │  │  ├─ report.md
│  ├─ # ... other projects ...

monorepo - pull request

.code-pushup/
├─ .ci/
│  ├─ <project-name>/
│  │  ├─ .comparison/
│  │  │  ├─ report-diff.json
│  │  │  ├─ report-diff.md
│  │  ├─ .current/
│  │  │  ├─ report.json
│  │  │  ├─ report.md
│  │  ├─ .previous/
│  │  │  ├─ report.json
│  │  │  ├─ report.md # if cache not used
│  ├─ # ... other projects ...
│  ├─ .comparison/
│  │  ├─ report-diff.md

@matejchalk matejchalk added the 🐛 bug something isn't working label Mar 11, 2025
@matejchalk matejchalk self-assigned this Mar 11, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 ci labels Mar 11, 2025
@matejchalk matejchalk force-pushed the fix-overwritten-artifacts branch from 78eec14 to 30a2a96 Compare March 11, 2025 11:29
@matejchalk matejchalk marked this pull request as ready for review March 11, 2025 11:37
@matejchalk matejchalk requested review from vmasek and BioPhoton March 11, 2025 11:37
Copy link

github-actions bot commented Mar 11, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 71c15d9 with previous commit 45e2757.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 53 ↓ −0.7
Code coverage 🟢 90 🟢 90 ↑ +0.1
Documentation 🔴 23 🔴 23 ↓ −0.1
Security 🟡 67 🟡 67
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 4 audits improved, 👎 7 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 53 ↓ −0.7
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 4.7 s 🟨 5.4 s ↑ +15.2 %
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 3.4 s ↓ −5.7 %
Lighthouse Time to Interactive 🟥 12.2 s 🟥 13.7 s ↑ +13.1 %
Lighthouse Total Blocking Time 🟥 2,550 ms 🟥 3,910 ms ↑ +53.3 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.8 s ↑ +0.8 %
JSDoc coverage Functions coverage 🟥 452 undocumented functions 🟥 456 undocumented functions ↑ +0.9 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↑ +0.1 %
Code coverage Function coverage 🟩 92.8 % 🟩 92.8 % ↑ +0.1 %
JSDoc coverage Types coverage 🟥 212 undocumented types 🟥 213 undocumented types ↑ +0.5 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.8 % ↑ +0.1 %
JSDoc coverage Variables coverage 🟥 203 undocumented variables 🟥 204 undocumented variables ↑ +0.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,837 KiB 🟩 Total size was 1,832 KiB ↓ −0.3 %
Lighthouse Minimizes main-thread work 🟥 11.5 s 🟥 15.0 s ↑ +30 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +13 %
Lighthouse JavaScript execution time 🟥 5.2 s 🟥 6.5 s ↑ +26.4 %
Lighthouse Max Potential First Input Delay 🟥 1,760 ms 🟥 1,930 ms ↑ +9.3 %
Lighthouse Initial server response time was short 🟩 Root document took 370 ms 🟩 Root document took 490 ms ↑ +34.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 930 ms 🟥 Potential savings of 860 ms ↓ −7.8 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 100 ms ↓ −24.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↑ +19.3 %

575 other audits are unchanged.

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matejchalk matejchalk merged commit 3c7fa08 into main Mar 11, 2025
20 checks passed
@matejchalk matejchalk deleted the fix-overwritten-artifacts branch March 11, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 ci 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report artifacts overwritten in CI
2 participants