UITransform priority change #8435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandamicro
reviewed
Apr 10, 2021
cocos/2d/framework/ui-transform.ts
Outdated
| @@ -213,8 +213,7 @@ export class UITransform extends Component { | |||
| } | |||
|
|
|||
| this._priority = value; | |||
| this._checkAndSortSiblings(); | |||
| this.node.parent!._updateSiblingIndex(); | |||
| this._priorityDirty = true; | |||
There was a problem hiding this comment.
If we remove this property, why add dirty to it ? Is there any problem ?
SantyWang
reviewed
Apr 14, 2021
cocos/2d/framework/ui-transform.ts
Outdated
| // 这个 dirty 是由子节点带来 dirty，其实是指的是子节点要不要重排 // 如果子节点要重排就在这里排 | ||
| UITransform._sortChildrenSibling(node); | ||
| node._updateSiblingIndex(); | ||
| node.emit('SiblingChange'); |
There was a problem hiding this comment.
这里就不是 sibling change 了，而是 children change
SantyWang
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos-creator/3d-tasks/issues/5790
Re: https://github.com/cocos-creator/3d-tasks/issues/4472