Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocket potential crash while exiting game or restarting ScriptEngine. #18351

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Feb 19, 2025

Re: #18340

Continue: #17609

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo February 19, 2025 07:03
Copy link

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001794 bytes 1001794 bytes ✅ 0 bytes
2D All (legacy pipeline) 2408779 bytes 2408779 bytes ✅ 0 bytes
2D All (new pipeline) 2498268 bytes 2498268 bytes ✅ 0 bytes
(2D + 3D) All 5380494 bytes 5380494 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16603945 bytes 16603945 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar merged commit fca7d7b into cocos:v3.8.6 Feb 21, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants