test: Throttle browser upload speed in testUpload #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait until the "project" directory is loaded before trying to drop a file into it. Otherwise the test sometimes failed because the previous /home/admin directory already contains a `drag-drop-testfile.txt` which triggered the replace dialog.
Most recent Chromium 133's BiDi driver regresses large uploads: They completely clog and eventually crash the BiDi web socket. Fortunately we can use a CDP command escape hatch to throttle the upload speed [1]. There is no BiDi API for that, so we cannot do the same approach with Firefox -- but that is happy with big uploads, so keep current behaviour there. [1] https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-emulateNetworkConditions
martinpitt
force-pushed
the
chromium-upload
branch
from
06a48b4 to
6f3fed3
Compare
|
Hmm, I don't get this failure locally. Looks like the upload is way too fast, i.e. the throttling isn't effective. However, I only tested it on the new container, not the previous one. Comparing with #968 I can't figure it out locally. Maybe the CDP command fails, which will be fixed by cockpit-project/cockpit#21650 . Testing with a trace-enabled run now. That's not it, the command succeeds. |
martinpitt
force-pushed
the
chromium-upload
branch
from
6a36cfa to
9fc2335
Compare
|
I can reproduce the failure in the old container with chromium 132. Apparently the throttling just doesn't work there. So I'll just merge this into #968. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most recent Chromium 133's BiDi driver regresses large uploads: They completely clog and eventually crash the BiDi web socket.
Fortunately we can use a CDP command escape hatch to throttle the upload speed [1]. There is no BiDi API for that, so we cannot do the same approach with Firefox -- but that is happy with big uploads, so keep current behaviour there.
[1] https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-emulateNetworkConditions
See #968, this helps. However, locally the test fails/flakes much later on for me (missing "File uploaded" alert), let's get the bots' opinion. Update: Fixed.