-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InvalidLinkBear: Remove FTP from regex #948
Conversation
Thanks for your contribution! Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well! |
Hey, it appears that appveyor failes due to some bad import that is fixed in another pr. Wait untill that one is merged. Thanks. |
aaaand it was fixed, please rebase and everything will pass! :) |
Remove 'ftp' from regex variable in `find_links_in_file()` method because Python `requests` library can't fetch the FTP status code. Closes coala#906
9baaa94
to
89e1108
Compare
@Adrianzatreanu rebased |
ack 89e1108 |
@rultor merge |
@Adrianzatreanu OK, I'll try to merge now. You can check the progress of the merge here |
@Adrianzatreanu Done! FYI, the full log is here (took me 1min) |
Remove 'ftp' from regex variable in
find_links_in_file()
method because Python
requests
library can't fetch the FTPstatus code.
Closes #906