Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvalidLinkBear: Remove FTP from regex #948

Merged
merged 1 commit into from
Oct 29, 2016

Conversation

refeed
Copy link
Member

@refeed refeed commented Oct 28, 2016

Remove 'ftp' from regex variable in find_links_in_file()
method because Python requests library can't fetch the FTP
status code.

Closes #906

@gitmate-bot
Copy link
Collaborator

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

@stefanbalas
Copy link
Contributor

Hey, it appears that appveyor failes due to some bad import that is fixed in another pr. Wait untill that one is merged. Thanks.

@Adrianzatreanu
Copy link
Contributor

aaaand it was fixed, please rebase and everything will pass! :)

Remove 'ftp' from regex variable in `find_links_in_file()`
method because Python `requests` library can't fetch the FTP
status code.

Closes coala#906
@refeed
Copy link
Member Author

refeed commented Oct 29, 2016

@Adrianzatreanu rebased

@Adrianzatreanu
Copy link
Contributor

ack 89e1108

@Adrianzatreanu
Copy link
Contributor

@rultor merge

@rultor
Copy link

rultor commented Oct 29, 2016

@rultor merge

@Adrianzatreanu OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 89e1108 into coala:master Oct 29, 2016
@rultor
Copy link

rultor commented Oct 29, 2016

@rultor merge

@Adrianzatreanu Done! FYI, the full log is here (took me 1min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants