ESLintBear: Return on empty output

[sils]

Fixes #727

@underyx can you review this?

[underyx]

@sils1297 how do you trigger empty output?

[sils]

by providing a good file without errors I think

[Adrianzatreanu]

wip as its not even passing tests

[sils]

damn!

Sincerely,

Lasse Schuirmann

lasse@schuirmann.net
http://coala-analyzer.org/ - http://viperdev.io/ - http://gitmate.com/

On 29 August 2016 at 17:12, Zatreanu Adrian-Gabriel <
notifications@github.com> wrote:

wip as its not even passing tests

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#728 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFc6KFkkl_vhHhpsiKfOlPK9vCdpo7j2ks5qkvbrgaJpZM4JvZf2
.

[Adrianzatreanu]

Hi,

it looks like your PR is out of date and needs a rebase. This page may help you to get started on this. (Do not press the update branch button. It's evil.)

We also have a quick video tutorial on how to rebase: https://asciinema.org/a/78683. That should help you understand the basics of how it works and what you should be doing.

Add the original coala repository as a remote:

git remote add upstream https://github.com/coala-analyzer/coala.git

Then go to your branch and rebase it onto our master:

git checkout <yourbranch>
git fetch upstream
git rebase --interactive upstream/master

Now push it up. You will need to do a force push because you change history here (do not do this on master branches :)):

git push --force

If you're just looking to fix an issue very quickly and not interested in contributing to coala long term, we can fix it up for you - just tell us :).

Ping us on our gitter channel if you need help!

[sils]

Oh thanks for the information! I wouldn't be able to do it otherwise, I was really scared to ask :(

[AbdealiLoKo]

I'm closing this, as it's not needed Can't see any usecase where the patch works

[sils]

Cool I'll look out for a reproduction. If I don't manage, this is for the better.

[underyx]

@sils1297 I just ran ESLint v2.13.1 on a project with no errors and it had no output; seems to be that simple.

Edit: Updated to v3.4.0, still no output.

Edit 2: Never mind, I'm a sillyhead as well; I wasn't using the arguments coala is using.