Update requirements.txt and README #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NLTK version increase
Added C in supported languages list
harshdattani
changed the title
|
hey, could you take a look at http://coala.readthedocs.io/en/latest/Getting_Involved/Writing_Good_Commits.html#how-to-write-good-commit-messages ? For the first commit you'll want to have e.g. "requirements.txt: Increase NLTK version" which holds more precise information in the shortlog. Also you'll want to have a |
|
(you can use |
| @@ -24,7 +24,7 @@ cmakelint==1.* | |||
| vim-vint==0.3.* | |||
| # Stable version 3.2 is problematic in Windows. | |||
| # Use >=3.3,==3.* once nltk-3.3 is released. | |||
| nltk==3.1.* | |||
| nltk==3.2.* | |||
There was a problem hiding this comment.
did you read the comment in line 25? Sounds like we don't want this
|
@sils1297 Thanks! Got it! |
|
@harshdattani ping :D |
|
Hey? Still aroudn? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLTK version increase #509