Improve description of KeywordBear #1274
Comments
|
Consider the test file
we get this patch - Now for this test file
we get this patch - .coafile -
|
|
looks more like a bug to me, because it doesn't detect the second line^^ |
|
Actually it detects the second line but doesn't propose a patch for it. |
|
that's what I wanted to say :P 🎉 |
|
I think it shouldn't propose a patch at all. It has just got to find the position of the keyword. That's it. |
|
@Techievena we offer the user a patch to remove the comment, that should happen for both todos in the example^^ he doesn't have to accept it :) |
|
Well I'm getting this kind of result |
|
|
|
|
|
yes as you see you can't apply the patch for the second |
|
first one is same as mine.. and in second screenshot you also messed up a bit with coafile. :P |
|
@aptrishu No the coafile is actually the same. I've just copied the file. Actually both the results are different. The first one asks for a patch for Keyword |
|
yeah you gotta prefix |
Propose patches to the user for all the keywords found in the file. Fixes coala#1274
Propose patches to remove all the comments in which keywords are found in the file. Fixes coala#1274
Propose patches to remove all the comments in which keywords are found in the file. Fixes coala#1274
Propose patches to remove all the comments in which keywords are found in the file. Fixes coala#1274
Propose patches to remove all the comments in which keywords are found in the file. Fixes coala#1274
|
@Techievena that little patch did fix this issue? :D |
|
btw could you make a test for this if possible? You can open up another issue for it^^ |
|
|
|
This one perfectly fits in this @Makman2 😆 . Now I have taken up one medium and a low issue related to Java (and me being completely ignorant about the package system and all stuffs related to Java). Those issues will take some time. I promise I'll work on this as soon as I'm finished with them. |
Add test for coala#1274 The test checks the diff to make sure that it proposes a patch to remove the comments even for multiple comments. Closes coala#1306
Add test for coala#1274 The test checks the diff to make sure that it proposes a patch to remove the comments even for multiple comments. Closes coala#1306
Add test for coala#1274 The test checks the diff to make sure that it proposes a patch to remove the comments even for multiple comments. Closes coala#1306
Add test for coala#1274 The test checks the diff to make sure that it proposes a patch to remove the comments even for multiple comments. Closes coala#1306
Add test for coala#1274 The test checks the diff to make sure that it proposes a patch to remove the comments even for multiple comments. Closes coala#1306
Propose patches to remove all the comments in which keywords are found in the file. Fixes coala#1274
Why does it check for comment ranges in the code, explain it a bit in the description . I'm getting inconsistent patch on different files. Description in comments.
Opened via gitter by @aptrishu
The text was updated successfully, but these errors were encountered: