Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install glew #139

Closed
wants to merge 3 commits into from
Closed

Conversation

mrodozov
Copy link

No description provided.

…he correct way will be to ship it as well with ROOT
@cmsbuild
Copy link

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch cms/master/e2c9e16.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mrodozov added a commit to cms-sw/cmsdist that referenced this pull request May 11, 2020
@cmsbuild
Copy link

cmsbuild commented May 11, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5813,cms-sw/cmssw#29740
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6222/console Started: 2020/05/11 17:27

@smuzaffar
Copy link

@mrodozov , is not it same as root-project#5583 ?

@cmsbuild
Copy link

-1

Tested at: c8a1ff2

  • Build:

I found compilation warning when building: See details on the summary page.

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f13ff6/6222/summary.html

@cmsbuild
Copy link

Pull request #139 was updated.

@cmsbuild
Copy link

Pull request #139 was updated.

@mrodozov
Copy link
Author

It's the same I wanted to see if it builds with this

Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>
@cmsbuild
Copy link

Pull request #139 was updated.

@oshadura
Copy link

oshadura commented May 12, 2020

@smuzaffar @mrodozov fix is in the ROOT master, sorry for delay and thanks for reporting!

@smuzaffar
Copy link

thanks @oshadura
@mrodozov , please update cms-sw/cmsdist#5813 to get latest root commit.

@smuzaffar smuzaffar closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants