-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alpaka modifier to HLTHgcalTiclPFClusteringForEgammaUnseededSequence #45427
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45427/40878 |
A new Pull Request was created by @waredjeb for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable gpu |
test parameters:
|
type hgcal, bug-fix |
@cmsbuild, please test |
|
||
_HLTHgcalTiclPFClusteringForEgammaUnseededSequence_heterogeneous = cms.Sequence(hgcalDigis+HGCalUncalibRecHit+HGCalRecHit+particleFlowRecHitHGC+hltHgcalSoARecHitsProducer+hltHgcalSoARecHitsLayerClustersProducer+hltHgcalSoALayerClustersProducer+hltHgCalLayerClustersFromSoAProducer+hgcalLayerClustersHSci+hgcalLayerClustersHSi+hgcalMergeLayerClusters+filteredLayerClustersCLUE3DHigh+ticlSeedingGlobal+ticlLayerTileProducer+ticlTrackstersCLUE3DHigh+particleFlowClusterHGCalFromTICLUnseeded+particleFlowSuperClusterHGCalFromTICLUnseeded) | ||
|
||
from Configuration.ProcessModifiers.alpaka_cff import alpaka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For internal TSG consideration, this type of pattern was already introduced at #45178, but it is somehow at odds with the current (Run3) customization paradigm. Should we consider creating a customizeHLTForCMSSW
-equivalent for the phase2 menu and put there all the necessary customizations for alpaka?
That way it will be easier to remove when the alpaka
modifier becomes the "norm".
I guess this also depends very much on how we want to store the phase2 menu in the long term.
@VourMa @SohamBhattacharya @fwyzard @Martin-Grunewald @missirol
+1 Size: This PR adds an extra 12KB to repository
Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
GPU Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR is meant to fix #45426 adding the alpaka procModifier to
HLTHgcalTiclPFClusteringForEgammaUnseededSequence
adding the correct sequence needed after the introduction of #45178Test
Tested on workflow 24834.402 (D98)
Would need to test on workflow with
alpaka
procModifier enabled, for example the *402 workflows.