-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MCMultiParticleMassFilter.cc #45344
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40757
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40758
|
A new Pull Request was created by @MohitS704 for master. It involves the following packages:
@GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @cmsbuild, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40772
|
Pull request #45344 was updated. @GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @cmsbuild, @menglu21, @mkirsano can you please check and sign again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, besides the comments inline, one more question:
in the case of there are 3 particles pass the kinematic cuts, and you are requiring a selection on two particles, will your code consider the combination of the first and the third particle.
GeneratorInterface/GenFilters/plugins/MCMultiParticleMassFilter.cc
Outdated
Show resolved
Hide resolved
GeneratorInterface/GenFilters/plugins/MCMultiParticleMassFilter.cc
Outdated
Show resolved
Hide resolved
I realized earlier that I had neglected to include this case. This is now covered by the for loop at the end of the |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40782
|
Pull request #45344 was updated. @GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @cmsbuild, @menglu21, @mkirsano can you please check and sign again. |
@menglu21 Are these changes suitable? |
@cmsbuild please test |
+1 Size: This PR adds an extra 12KB to repository
Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adding a new PYTHIA filter that checks whether the sum of all the particles (that pass a specific pt and eta cut) has a mass between the values that you set. This is based off of the idea raised in this CMS-talk post. Even though the post (and the branch name) imply that the filter is for the 4-lepton channel only, it can easily be used in other channels, as the only inputs are the PDG IDs of the particles you would like.
PR validation:
I've tested the filter to see that it does in fact only let through particles with the IDs that you specify, and that it will only allow events with particles that pass the pt and eta cuts which sum to a vector that has an invariant mass between the specified maximum and minimum values.
I think I did the previous PR incorrectly. That one is linked here, and is functionally identical.