Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MCMultiParticleMassFilter.cc #45344

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Create MCMultiParticleMassFilter.cc #45344

merged 4 commits into from
Jul 15, 2024

Conversation

MohitS704
Copy link
Contributor

PR description:

Adding a new PYTHIA filter that checks whether the sum of all the particles (that pass a specific pt and eta cut) has a mass between the values that you set. This is based off of the idea raised in this CMS-talk post. Even though the post (and the branch name) imply that the filter is for the 4-lepton channel only, it can easily be used in other channels, as the only inputs are the PDG IDs of the particles you would like.
PR validation:

I've tested the filter to see that it does in fact only let through particles with the IDs that you specify, and that it will only allow events with particles that pass the pt and eta cuts which sum to a vector that has an invariant mass between the specified maximum and minimum values.

I think I did the previous PR incorrectly. That one is linked here, and is functionally identical.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40757

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40758

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @MohitS704 for master.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @cmsbuild, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40772

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

Pull request #45344 was updated. @GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @cmsbuild, @menglu21, @mkirsano can you please check and sign again.

Copy link
Contributor

@menglu21 menglu21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, besides the comments inline, one more question:
in the case of there are 3 particles pass the kinematic cuts, and you are requiring a selection on two particles, will your code consider the combination of the first and the third particle.

@MohitS704
Copy link
Contributor Author

Hi, besides the comments inline, one more question: in the case of there are 3 particles pass the kinematic cuts, and you are requiring a selection on two particles, will your code consider the combination of the first and the third particle.

I realized earlier that I had neglected to include this case. This is now covered by the for loop at the end of the recurseLoop function that instantiates the recursion over the rest of the vector in the most recent commit.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45344/40782

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

Pull request #45344 was updated. @GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @cmsbuild, @menglu21, @mkirsano can you please check and sign again.

@MohitS704
Copy link
Contributor Author

@menglu21 Are these changes suitable?

@menglu21
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-071c6b/40339/summary.html
COMMIT: 8e6114d
CMSSW: CMSSW_14_1_X_2024-07-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45344/40339/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 26 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 857
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344217
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants